csup: fix panic in metadataValue#7119
Merged
Merged
Conversation
Collaborator
|
I'm still getting the panic from #7109 on this branch. Here's my simplified repo: $ echo '{x?:{y:"foo"}}' | super -f csup -o t.csup -
$ super -c 'from t.csup | where x.y = "foo"'
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
/opt/homebrew/Cellar/go/1.26.3/libexec/src/runtime/debug/stack.go:26 +0x64
github.com/brimdata/super/runtime/vam/op.(*Catcher).Pull.func1()
/Users/nibs/Code/super/runtime/vam/op/mux.go:26 +0x34
panic({0x1056ce000?, 0x105b32870?})
/opt/homebrew/Cellar/go/1.26.3/libexec/src/runtime/panic.go:860 +0x12c
github.com/brimdata/super/csup.metadataValue(0x7a484944000, 0x7a484cdb180, 0x7a484e2f460, 0x84beb7a0?, {0x7a484847bf0, 0x1, 0x1})
/Users/nibs/Code/super/csup/metadata.go:354 +0xd98
github.com/brimdata/super/csup.metadataValue(0x7a484944000, 0x7a484cdb180, 0x7a484e2f460, 0x7e38e10?, {0x7a484847bc0, 0x1, 0x1})
/Users/nibs/Code/super/csup/metadata.go:336 +0x994
... |
Member
Author
|
@mattnibs: The panic is really fixed now. |
Collaborator
|
@nwt the panic is gone but not I'm not getting results from either the o.g. bsky query or my simplified query when they should: Either way I think we should add a test case to this pr. |
Member
Author
mattnibs
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7109.